search

noctuid / link-hint.el

Pentadactyl-like Link Hinting in Emacs with Avy
GNU General Public License v3.0
160 stars 22 forks source link

Fix the regression of deadgrep support and a few other suggestions #227

Closed akirak closed 2 months ago

akirak commented 2 months ago

Hi,

The deadgrep support seems to be broken. It no longer highlights matches, and this PR fixes the issue.

Also link-hint--deadgrep-link-at-point-p returned only a line number, which is somewhat hard to understand. I would propose a change to the filename:line-number format.

Finally, it would be nice if the links were opened in another window so I can browse many links using link-hint. What do you think? Is it better to leave it as it is?

noctuid commented 2 months ago

Thanks!

Finally, it would be nice if the links were opened in another window so I can browse many links using link-hint. What do you think? Is it better to leave it as it is?

I think it's better to leave it as-is by default for consistency with the other link types. The user can always change the :open function or add a new action

akirak commented 2 months ago

I think it's better to leave it as-is by default for consistency with the other link types.

I have reverted the change. Thanks.

akirak commented 2 months ago

Thanks!