search

noctuid / link-hint.el

Pentadactyl-like Link Hinting in Emacs with Avy
GNU General Public License v3.0
160 stars 22 forks source link

Changes in Emacs master break link-hint in customize buffers #231

Closed dsedivec closed 1 week ago

dsedivec commented 1 month ago

https://github.com/emacsmirror/emacs/commit/2f18929319a4883575acb7440c920ad059a84105: the change here to widget-move, as used by link-hint--next-widget (via widget-forward) will no longer get an error when you're at the last widget in a buffer, instead it just doesn't move point. This results in a tight infinite loop if link-hint runs in a customize buffer.

I'm thinking to fix this by checking if point moved after widget-forward. Would you like a PR?

noctuid commented 4 weeks ago

PR welcome. Should work with both the old and new widget-move behavior. link-hint--next-widget-button already kind of behaves this way but with the additional link-hint--widget-button-at-point-p check, which I think was either unnecessary or wrong for customize buffers.

dsedivec commented 1 week ago

PR #232 opened. Amusingly, this fix will probably not work under Emacs master as of a day or three ago, but I think that is Emacs's fault now. I filed https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72995.