search

noctuid / lispyville

lispy + evil = lispyville
GNU General Public License v3.0
315 stars 23 forks source link

Add lispyville-delete-back-to-indentation #62

Closed yunhao94 closed 4 years ago

yunhao94 commented 4 years ago

evil add an evil-want-C-u-delete option in https://github.com/emacs-evil/evil/commit/33bb8534f6f8d12ae071cb12a38db6306cb07f87, this PR implement a safe version of evil-delete-back-to-indentation

noctuid commented 4 years ago

Are tests passing for you locally? They are failing for me:

Test lispyville-delete-back-to-indentation condition:
    (ert-test-failed
     ((should
       (string=
        (lispyville-with "(foo bar
     foobar|)" "i C-u")
        "(foo bar
     |)"))
      :form
      (string= "(foo bar
     foobar|)" "(foo bar
     |)")
      :value nil))

Other tests are now failing after updating packages with make cask. It's okay if other tests fail (I'll have to fix them), but lispyville-delete-back-to-indentation tests should all pass.

Also, if you get a chance could you put the custom-set-variables calls inside the ert-deftest (minor preference) and squash your commits?

yunhao94 commented 4 years ago

Sorry for the failed test. The commits are squashed, and the lispyville-delete-back-to-indentation test passes locally now. Please review.

noctuid commented 4 years ago

Awesome, thanks!