nod-ai / SHARK-ModelDev

Unified compiler/runtime for interfacing with PyTorch Dynamo.
Apache License 2.0
95 stars 48 forks source link

TfIdfVectorizer #743

Closed vivekkhandelwal1 closed 3 months ago

PhaneeshB commented 5 months ago

If someone picks this up before me - having looked at torch for similar ops (also in torchtext) and not finding a direct mapping (maybe some ops from torchtext can be used paritally) I would suggest, to take the sklearn impl (which is widely used in practice) for TFIDFVectorization Or the onnx impl as reference (convert to pyTorch impl first) to add the onnx to torch lowering.

vivekkhandelwal1 commented 3 months ago

Implemented in https://github.com/llvm/torch-mlir/pull/3553