search

nod-ai / SHARK-TestSuite

Temporary home of a test suite we are evaluating
Apache License 2.0
5 stars 35 forks source link

[alt] remove default iree-compile extra args from onnx-iree mode #356

Closed zjgarvey closed 3 weeks ago

zjgarvey commented 1 month ago

Always using iree-input-demote-i64-to-i32 was causing numerics problems since it wasn't loading i64 inputs correctly. Additionally the flags for specifying the chip for hip is out of date, and should be removed. Users should specify -ica "iree-hip-target=gfx942" "other-arg" "other-arg" ... if compiling for Mi300.

zjgarvey commented 1 month ago

@ScottTodd Should I revert the change to the cl config to use --iree-hal-target-backends instead of --iree-hal-target-device?

ScottTodd commented 1 month ago

@ScottTodd Should I revert the change to the cl config to use --iree-hal-target-backends instead of --iree-hal-target-device?

That's probably safer for now. Since the new flag hasn't been fully adopted in the IREE repo and doesn't have much mileage on it, it may be buggy. That's going to be easier to reason about upstream first, and that sort of flag change can also be made independently from the rest of the cleanup here.