search

nod-ai / SHARK-Turbine

Unified compiler/runtime for interfacing with PyTorch Dynamo.
Apache License 2.0
82 stars 41 forks source link

GRU #723

Open renxida opened 4 weeks ago

renxida commented 4 weeks ago

taking these because these are going to be similar to https://github.com/nod-ai/SHARK-Turbine/issues/315 (lstm)

renxida commented 4 weeks ago

rnn and gru should be doable with a refactoring & adding some helper functions in:

https://github.com/nod-ai/SHARK-Turbine/issues/315

vivekkhandelwal1 commented 4 weeks ago

@renxida, can you please create 2 separate issues? That way, it would be easy to track them.

renxida commented 4 weeks ago

@vivekkhandelwal1 gru and lstm are special cases of rnn, and i expect that if i modify my lstm code to support RNNs in general, the same pr would support GRU also

vivekkhandelwal1 commented 4 weeks ago

@vivekkhandelwal1 gru and lstm are special cases of rnn, and i expect that if i modify my lstm code to support RNNs in general, the same pr would support GRU also

That's fine. I'll create a PR that will add 4 ops but in order to track them I have created 4 different issues. I'm just saying it's easy to track each op with a different issue instead of having multiple ops in the same issue.

renxida commented 4 weeks ago

oh ok! gotcha. i was assuming that there should be a 1-1 correspondance between issues and PRs. Will create another issue.