search

nod-ai / SHARK

SHARK - High Performance Machine Learning Distribution
Apache License 2.0
1.4k stars 169 forks source link

Clean up the filesystem stuff and add support for HF ckpt downloading #2127

Closed gpetters-amd closed 2 months ago

gpetters-amd commented 2 months ago

This works fine for SD2.1 but I've noticed an issue downloading the safetensors file for clip for SD1.5. There's still some more cleanup necessary here, so I'd appreciate a second pair of eyes on it. I'm also not sure if the way I'm centralizing all the filesystem logic (just using the args and calling os.path.join at each usage) is the right thing to do or if we want to have everything go through, say, functions in file_utils.py.

monorimet commented 2 months ago

Thanks @gpetters-amd. I left a few comments, but looks better for the most part.