search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
46 stars 23 forks source link

Add a second linux phoenix machine to CI #436

Open newling opened 2 weeks ago

newling commented 2 weeks ago

I think this task is already started. Once we have a second machine on the network, what are the steps to integrate it into the CI workflow? TBH the amount of time spent running tests on HW is quite low, and most building (IREE etc) is not done on the phoenix. So maybe we should reconsider even having this (@saienduri @nirvedhmeshram ) ?

I'm not too familiar with how github chooses which resource to run tests on.

makslevental commented 2 weeks ago

I'm not too familiar with how github chooses which resource to run tests on.

It's the runs-on tag in the yaml file.

TBH the amount of time spent running tests on HW... So maybe we should reconsider even having this

On the contrary I think we should increase the number of tests that run on hardware. As soon as I'm done with the other sprint, I plan to start expanding our testing matrix, and that includes expanding the set of on device tests. With that in mind another (1, 2, 5, or 10) device runner is a great idea and I'm fine taking on the task of "on-boarding" (the runner).