[Conv2d] Add lowering pipeline and tiling strategy for Conv2d

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator

Apache License 2.0

64 stars 29 forks source link

[Conv2d] Add lowering pipeline and tiling strategy for Conv2d #461

Closed yzhang93 closed 3 months ago

yzhang93 commented 3 months ago

This is the first PR to add C++ pipeline for Conv2d ops. This PR added a new lowering pipeline for Conv2d (conv_2d_nchw_fchw / conv_2d_nhwc_hwcf). The tiling strategy is following the tile sizes shown in transform dialect, and some dimensions are hardcoded for now. We can explore more on the tiling strategy once simple example working e2e.

yzhang93 commented 3 months ago

Looks good, only minor comments. The PR title is

[Conv2d] Add lowering pipeline and tiling strategy for Conv2d

But it only adds the tiling strategy AFAICT?

Yeah, my intention for this first PR was just to add a new lowering pipeline conv-decompose. The tiling strategy need to be paired with the pipeline. It doesn't include the building passes for the pipeline yet. Sorry for the confusion.