Bump iree, mlir-air, mlir-aie

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator

Apache License 2.0

45 stars 23 forks source link

Bump iree, mlir-air, mlir-aie #465

Closed daveliddell closed 5 days ago

daveliddell commented 6 days ago

Changes in updated submodules that require adaptation in iree-amd-aie:

NpuWriteBdOp lost its ddr_id argument
AIRPipeline.cpp was removed
mlir::ceilDiv and the rest of mlir/Support/MathExtras.h was removed in favor of the LLVM equivalents (https://github.com/llvm/llvm-project/pull/95087)

daveliddell commented 5 days ago

Hi @daveliddell, I just took a look at the failure test which is from AIESerializer.cpp test, and this code is actually no longer in use. We can safely delete those tests. Can you try to update all submodules to latest and try build it again?

Removed tests and associated obsolete code in PR https://github.com/nod-ai/iree-amd-aie/pull/475.

yzhang93 commented 5 days ago

Could you bump AIR and (maybe AIE) to latest again? We'd like to include Erwei's latest commits to test conv2d ops.

daveliddell commented 5 days ago

Could you bump AIR and (maybe AIE) to latest again? We'd like to include Erwei's latest commits to test conv2d ops.

Ok, I'll give it a try.

yzhang93 commented 5 days ago

Ok, I'll give it a try.

Thanks! If you haven't started doing a new bump, maybe we can merge this first because it has bump for IREE to unblock @erwei-xilinx. Then we can raise another PR bump mlir-air/aie again. I'm approving now.

daveliddell commented 5 days ago

Ok, I'll give it a try.

Thanks! If you haven't started doing a new bump, maybe we can merge this first because it has bump for IREE to unblock @erwei-xilinx. Then we can raise another PR bump mlir-air/aie again. I'm approving now.

Ok, that's good. I'm happy to do another bump, but I'd rather take it in two steps, in case I encounter more difficulties. Will land this one as soon as CI finishes. Thanks!