search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
45 stars 23 forks source link

Add objectFifo cpp pipeline #473

Closed jtuyls closed 1 day ago

yzhang93 commented 5 days ago

@jtuyls This is the change needed to make ci test pass. https://github.com/nod-ai/iree-amd-aie/pull/476

jtuyls commented 2 days ago

For sake of completeness it'd be nice to change the RUN command of matmul_peeled_objectfifo.mlir

This test starts on some intermediate IR so I don't think I can use the full pipeline. I will add another one that uses iree-compile

jtuyls commented 2 days ago

I'm happy to do some redesign work later, but I think we're introducing too many concepts, what is the difference between "backend" and "pipeline" here?

I think it'd be clearer to have 2 "pipelines" (they're just pipelines right?)

--iree-amdaie-tile-and-bufferizer-pipeline=a --iree-amdaie-lower-to-aie-pipeline=b

where a in A, b in B, still with A = {pack-peel, pad-pack, default-conv} B = {air, objectFifo}

We should also consider which pairs {a,b} in AxB are actually supported, and gate with clear errors for the other cases. Again, happy to postpose til a later PR.

Good point. I think these changes belong in this PR itself, so happy to still make them

jtuyls commented 1 day ago

@yzhang93 Could you check again?