search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
45 stars 23 forks source link

Update air pipeline for conv2d lowering, using conv-decompose pipeline #487

Closed erwei-xilinx closed 1 day ago

erwei-xilinx commented 3 days ago
yzhang93 commented 1 day ago

@newling After this PR merged, would you help add ci tests for Conv2d similar to what we have for matmul? I think we can use what is used in IREE https://github.com/iree-org/iree/blob/main/tests/e2e/convolution/generate_e2e_conv2d_tests.py.

newling commented 1 day ago

@newling After this PR merged, would you help add ci tests for Conv2d similar to what we have for matmul? I think we can use what is used in IREE https://github.com/iree-org/iree/blob/main/tests/e2e/convolution/generate_e2e_conv2d_tests.py.

You can easily add a test in cpu_comparison, @erwei-xilinx could add it in this PR if there is a numerically passing test?

erwei-xilinx commented 1 day ago

@newling After this PR merged, would you help add ci tests for Conv2d similar to what we have for matmul? I think we can use what is used in IREE https://github.com/iree-org/iree/blob/main/tests/e2e/convolution/generate_e2e_conv2d_tests.py.

You can easily add a test in cpu_comparison, @erwei-xilinx could add it in this PR if there is a numerically passing test?

Yeah would be really useful if we can add the numerical test in this PR.

yzhang93 commented 1 day ago

@newling After this PR merged, would you help add ci tests for Conv2d similar to what we have for matmul? I think we can use what is used in IREE https://github.com/iree-org/iree/blob/main/tests/e2e/convolution/generate_e2e_conv2d_tests.py.

You can easily add a test in cpu_comparison, @erwei-xilinx could add it in this PR if there is a numerically passing test?

Yes, we can have a quick numerical test using cpu_comparison at the moment. But in the long term, I think we'd want to use IREE's stand alone test module. I think it's faster and more flexible?

newling commented 1 day ago

Test can be added something like this: https://github.com/newling/iree-amd-aie/tree/add_conv_test

erwei-xilinx commented 1 day ago

Test can be added something like this: https://github.com/newling/iree-amd-aie/tree/add_conv_test

I cherry picked this commit and the test is passing. May I cherr-pick your commit into this PR and we land together?

newling commented 1 day ago

Test can be added something like this: https://github.com/newling/iree-amd-aie/tree/add_conv_test

I cherry picked this commit and the test is passing. May I cherr-pick your commit into this PR and we land together?

Wow that's surprising that it just worked. Thank you @erwei-xilinx !

erwei-xilinx commented 1 day ago

Test can be added something like this: https://github.com/newling/iree-amd-aie/tree/add_conv_test

I cherry picked this commit and the test is passing. May I cherr-pick your commit into this PR and we land together?

Wow that's surprising that it just worked. Thank you @erwei-xilinx !

Thanks for putting together the test!