search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
46 stars 23 forks source link

Use upstream Xilinx/aie-rt #499

Closed makslevental closed 4 days ago

makslevental commented 1 week ago

This PR moves us to using Xilinx/aie-rt; in particular the release/main_aig branch which is part of the Linux Foundation upstreaming agreement/deal.

Note, this one and https://github.com/nod-ai/iree-amd-aie/pull/501 are logically independent even though they touch some of the same files/lines. Whichever lands first, I'll just rebase the other.

cc @kumardeepakamd

makslevental commented 6 days ago

Can we avoid adding these binary elf files used in the tests? E.g. generating them instead?

Obv I can but

  1. Then I would also be testing peano and linking and the lowering pipelines;
  2. In point of fact, one thing I was double checking here (obliquely) was that my local (up to date) peano and peano on the runner are producing valid code. Locally I could not (with this patch) get the matmul tests to pass numerics (and still cannot). So I generated these locally and watched to see whether the runner matmul tests would fail. I say obliquely because I really need to compare the elfs generated by the runner to these and/or execute these and check numerics.

Ok that I realize that doesn't make complete sense but basically what I'm saying is since all this stuff is so brittle, when something breaks, we have basically no way of knowing where exactly a break happens. Now usually you could narrow the tests by reproducing the environment but the issue for this PR was I have no idea what version of peano is on the runner (that's why one of the commits was just to print time stamps for that directory, which only revealed it's from December). So the only way to debug that was this extremely narrow unit test. Going forward we should obviously pin to a hash of peano and that'll be possible soon (when they're satisfied with https://github.com/Xilinx/llvm-aie/pull/109). At that point I'll be able to delete these.

makslevental commented 6 days ago

Will move stuff around to remove binaries from commit.