This is a refactor prior to the follow-up removal of this and other passes (in order to reduce the diff in the follow-up).
We remove aie.shim_dma support from the pass and XFAILtests that are legacy/erroneous from mlir-aie. E.g., aie.device(npu1_4col) does not support aie.shim_dma (recall we use runtime instructions to program shim DMAs on IPU/NPU).
Note, there are a lot of lines changed; probably easiest to first skim the entire file as a whole rather than as a diff.
Feel free to nitpick/bikeshed - it'll help me "robustify" the final version in the follow-up.
This is a refactor prior to the follow-up removal of this and other passes (in order to reduce the diff in the follow-up). We remove
aie.shim_dmasupport from the pass andXFAILtests that are legacy/erroneous frommlir-aie. E.g.,aie.device(npu1_4col)does not supportaie.shim_dma(recall we use runtime instructions to program shim DMAs on IPU/NPU).Note, there are a lot of lines changed; probably easiest to first skim the entire file as a whole rather than as a diff.
Feel free to nitpick/bikeshed - it'll help me "robustify" the final version in the follow-up.