search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
69 stars 30 forks source link

[CanonicalizeDoublyStridedOp] Fix single dimension folder #737

Closed newling closed 2 months ago

newling commented 2 months ago

I'm starting to look deeper into creating links when the circular_dma_cpy_nd's being linked are not mutually 'contiguous'. Noticed that Attributes become Constant ops unnecessarily in create-logical-objectfifo-link, so fixed this by removing getValueOrCreateConstantIndexOp. Then noticed that test canonicalize_doubly_strided_op.mlir was failing, and this was because .getTargetStrides was being used where getTargetMixedStrides should've been, so fixed that. Also removed a redundant canonicalization call (print-ir-after-all showed 2 contiguous canonicalizations)

makslevental commented 2 months ago

It's because it's a fork... Whoops