search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
69 stars 30 forks source link

Refactor packToDma pass to work directly with objectFifo #776

Closed yzhang93 closed 2 months ago

yzhang93 commented 2 months ago

It's not necessary to go from LinalgExt::PackOp -> air::DmaMemcpyNdOp -> AMDAIE::DmaCpyNdOp. With packToDma pass decoupled from AIR pipeline in https://github.com/nod-ai/iree-amd-aie/pull/773, we can refactor the codes to convert directly from PackOp to AMDAIE::DmaCpyNdOp. As a consequence, AIRDmaToAMDAIEDma pass is eliminated.

I'm also thinking maybe it's good to rename AMDAIEPackToDma to AMDAIEPackToLogicalObjectFifoDma?