nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
69 stars 30 forks source link

[ConvertToUnpack] Apply correct permutation when lowering unpack to DMA #794

Closed newling closed 1 month ago

newling commented 1 month ago

Inverse permutation needs to be applied when converting unpack to DMA, not permutation. PR adds test with permutation P != P^{-1}, without which this bug is hidden. I've left a comment with that test explaining why this fix is required. Also, --cse is removed from the test lit command, to reduce noise.