Closed makslevental closed 1 month ago
Off the top of my head things which we need to reach parity, hopefully we can reuse what's already done in cpu_comparison/run.py:
Also, can you/someone please at some point:
keep track of migration of tests from old script to pytest, ideally they shouldn't be run in both places. Or maybe they've all been moved already?
None have been moved, some have been duplicated.
This PR begins the migration to
pytest
for all of oure2e
tests using IREE's python bindings for both the compiler and the runtime. I've tested it thoroughly (by runningrun_matmul.sh
andcpu_comparison/run.py
~100~50 times).Two major changes were required to make this happen:
AMDAIEOptions
so that they're registered at plugin load time. This was necessary for enablingSession.set_flags
in Python. Going forward we should make sure to put all CLI args in the same place;1536x2048x1536
that was prior disabled for Windows but is now disabled entirely. I don't know what the connection is (I wasn't able to track it down) but since every other test passes, including the 1000 run test, and even after repeating overall ~100~50 runs, I think it's safe to conclude there's something wrong with that shape rather than the HAL.The migration isn't complete because the bindings and the VM itself don't support bf16 yet; I will send them a PR soon.
Note, in its current state the test scripts run ~100~50 times. I will remove this before landing.
TODO (for the next iteration): right now
repeat_runs
doesn't work because of how the XRT command buffer works (it's free'ed after every dispatch and with it thexrt::kernel
andxrt::hw_context
). Likely I'm doing something wrong (possibly using the wrong command buffer model) so I think it should be fixable.