search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
69 stars 30 forks source link

Enable optional packet flow connections between L3 and L2 #797

Closed jtuyls closed 1 month ago

jtuyls commented 1 month ago

Adds initial e2e support for packet flows via the iree-amdaie-enable-packet-flow flag. This PR only enables it on connections between L3 and L2 as there is still a hang issue for larger matmul problems with packet routing between L2 and L1.

This PR includes the fixes from: https://github.com/Xilinx/mlir-aie/pull/1683

Fixes: #674

makslevental commented 1 month ago

I'll take a closer look today but 1 nit: can you rename msel to masterSelect and amsel (if it appears anywhere) to arbiterMasterSelect. Because we're but being charged my the letter...

jtuyls commented 1 month ago

I'll take a closer look today but 1 nit: can you rename msel to masterSelect and amsel (if it appears anywhere) to arbiterMasterSelect. Because we're but being charged my the letter...

I can do this, but personally, I don't mind amsel/msel etc after getting familiar with it (and msel is consistent with naming in the spec).

Because we're but being charged my the letter...

Sure, but I have a file named amsel_generator.cc, which would become arbiter_and_master_select_generator.cc, which is unnecessarily long imo.