search

nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
69 stars 30 forks source link

[FuncOutline] Fix function outlining to skip linalg.fill/linalg.skip #888

Closed Abhishek-Varma closed 1 week ago

Abhishek-Varma commented 1 week ago

-- This commit fixes function outlining to skip linalg.fill/linalg.skip -- Without this linalg::isElementwise(LinalgOp) seems to be qualifying both as elementwise ops.

Signed-off-by: Abhishek Varma abhvarma@amd.com

yzhang93 commented 1 week ago

Can you report the matmul performance w/wo this PR?

newling commented 1 week ago

@Abhishek-Varma If you want to measure time (and you don't already know what I'm about to say..) you can add <chrono> to measure time around here: https://github.com/nod-ai/iree-amd-aie/blob/9b0582f3cc7e04b9f1747e115e2ee43225ab77f0/runtime/src/iree-amd-aie/driver/xrt-lite/direct_command_buffer.cc#L193