nod-ai / iree-amd-aie

IREE plugin repository for the AMD AIE accelerator
Apache License 2.0
69 stars 30 forks source link

CI system for windows shall use the NPU driver released by Microsoft windows #902

Closed dezhiAmd closed 1 week ago

dezhiAmd commented 1 week ago

On Windows OS, every device driver needs to be signed by Microsoft so that all applications can use the same driver and work together such as MEP is supported by XRT driver (Refer to https://support.microsoft.com/en-us/windows/windows-studio-effects-273c1fa8-2b3f-41b1-a587-7cc7a24b62d8). This also applies to NPU devices developed by AMD.

Currently the CI computer is not using the NPU driver released by AMD.

makslevental commented 1 week ago

needs to be signed by Microsoft so that all applications can use the same driver and work together such as MEP is supported by XRT driver

Since we don't use any other applications on that runner, this doesn't apply to us. Indeed the playbook instructions literally tells you to regedit out the requirement for signatures. So there's no issue here.

dezhiAmd commented 1 week ago

Without using the driver released by Microsoft, the test result on CI may differ from the real system used by general public

makslevental commented 1 week ago

Without using the driver released by Microsoft, the test result on CI may differ from the real system used by general public

We don't currently support Windows for the "general public" so that's fine. Please don't re-open this issue. We are not going to change the driver on the CI machine.