Open pdhirajkumarprasad opened 4 days ago
can you send me the machine that needs these via slack
Those tests should still be changed to not depend on the contents of the runner file system. Users and developers should be able to run these tests on their own systems.
HF_HOME
, or SHARK_HOME
), not hardcoded paths (and especially not hardcoded paths that won't work at all on Windows)If the downloads are small enough, the test could download and cache automatically. For larger models, I'd probably fail the test (or skip with a reason) and print instructions to run some setup.
@ScottTodd I agree. However, as someone who is grateful these tests were written at all, I went ahead and updated the fs for now. we can leave this issue open if you'd like to use it to track the desired modality
SGTM. I'll keep speaking up whenever it breaks and needs fixing though :P. We'll need the tests decoupled from the machines our team directly controls eventually if we want users or other developers to be able to run them too. (Though for 405b that's much harder than it is for smaller models)
In nightly, we have different decomposed models like
which are failing as parameter files are missing.
Error: