Closed sogartar closed 1 month ago
@stellaraccident I renamed __eq__
to is_deep_equal
.
I rebased and resolved conflicts.
@stellaraccident, I ran into this problem that when loading the dataset if we mem map, then even when deleting the Python objects, the underlying files are still open. I see that the files are memory mapped in IREE. I assume we are missing somewhere an ownership relation.
Discussed offline about possibly changing
__eq__
to something likeis_deep_equivalent
and documenting specifically what that means.