nod-ai / sharktank

SHARK Inference Modeling and Serving
Apache License 2.0
7 stars 9 forks source link

Add replicated tensor type and handle conv2d with sharded input channels #54

Closed sogartar closed 1 month ago

stellaraccident commented 1 month ago

Discussed offline about possibly changing __eq__ to something like is_deep_equivalent and documenting specifically what that means.

sogartar commented 1 month ago

@stellaraccident I renamed __eq__ to is_deep_equal.

sogartar commented 1 month ago

I rebased and resolved conflicts.

sogartar commented 1 month ago

@stellaraccident, I ran into this problem that when loading the dataset if we mem map, then even when deleting the Python objects, the underlying files are still open. I see that the files are memory mapped in IREE. I assume we are missing somewhere an ownership relation.