search

node-alarm-dot-com / homebridge-node-alarm-dot-com

Alarm.com plugin for Homebridge using Node.js
MIT License
58 stars 23 forks source link

Use nightArming option instead of aliasing silentArming #94

Closed ChadMoran closed 1 year ago

ChadMoran commented 2 years ago

Previously silentArming was used as a proxy for actually using nightArming. However, devices do have native support for this. In fact, using silentArming did not allow me to use nightArming with my DSC keypad. I considered changing the line that was setting silentArming to use an or conditional with night arming to maintain backwards compatibility. However, this would continue to cause anyone who had a keypad that wouldn't allow silentArming with nightArming to continue to fail.

Verified this using an actual keypad. It would silently fail (hah) before and now succeeds to arm to night mode successfully.

Note that anyone who was relying on this unexpected behavior may see a change moving forward. If this is a concern some sort of legacy flag can be implemented if needed.

chase9 commented 1 year ago

Unless I'm missing something, this has already been merged into recent versions of the plugin. Please give the latest version (1.9.0) a try and let me know if your issues is resolved.