search

node-apn / node-apn

:calling: Apple Push Notification module for Node.js
MIT License
4.37k stars 681 forks source link

Resolve vulnerabilities, update to node 10 or greater. #697

Open robhybrid opened 3 years ago

robhybrid commented 3 years ago

This Pull request resolves several vulnerabilities, including a severe vulnerability. A similar PR is open, but has failing builds. https://github.com/node-apn/node-apn/pull/695 This one is more comprehensive. The minimum version of Node will need to be updated from 4 to 10 to support the latest version of node-forge. The automated builds need to be updated because tests using Node version 6 and 8 will fail.

These libraries can probably be forked to support legacy node versions, but I don't consider it worth the effort, unless legacy support is absolutely necessary. Please let me know if you decide not to update to the builds to new versions.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d300043e28904e6e096ab9bb9774ce528d526731 on robhybrid:master into 38a357ed0c153aad09c2857e48a710527e685bfc on node-apn:master.