search

node-casbin / express-authz

express-authz is an authorization middleware for Express.js based on Casbin
https://casbin.org
Apache License 2.0
62 stars 9 forks source link

[Breaking Changes] Migrated to Typscript #10

Closed romitkarmakar closed 4 years ago

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 470

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/authz.ts 28 32 87.5%
<!-- Total: 46 50 92.0% -->
Totals Coverage Status
Change from base Build 250: 0.6%
Covered Lines: 49
Relevant Lines: 53
💛 - Coveralls
romitkarmakar commented 4 years ago

HTTP Basic Authentication has been fixed in this PR. For reference check: https://en.wikipedia.org/wiki/Basic_access_authentication

nodece commented 4 years ago

Please fix PR error.

romitkarmakar commented 4 years ago

PR error fixed

nodece commented 4 years ago

lgtm.

nodece commented 4 years ago

@romitkarmakar can we support override Authorizer？

romitkarmakar commented 4 years ago

@nodece this is a good idea. I will work on this issue and add a subsequent PR for custom Authorizer

romitkarmakar commented 4 years ago

@nodece can you publish the changes to npm.

hsluoyz commented 4 years ago

@nodece @romitkarmakar please also release on GitHub: https://github.com/node-casbin/express-authz/releases