search

node-casbin / prisma-adapter

Prisma adapter for Casbin
Apache License 2.0
31 stars 18 forks source link

chore(deps): bump prisma from v2 to v3 #39

Closed zillding closed 3 years ago

zillding commented 3 years ago

close #38

casbin-bot commented 3 years ago

@Gabriel-403 @Zxilly @kingiw @nodece please review

hsluoyz commented 3 years ago

@zillding package-lock.json ?

hsluoyz commented 3 years ago

@zillding fix:

image

zillding commented 3 years ago

@hsluoyz package-lock.json is updated together with package.json since the dev dependencies are also updated. Is that okay?

zillding commented 2 years ago

can we release this change to npm? thanks. 🙏

hsluoyz commented 2 years ago

@zillding we used semantic-release, which does auto-release based on the prefix. But you used chore(deps) prefix, which doesn't trigger new version. You have to make a new PR with "feat:" or "fix:" prefix to trigger a new version.

zillding commented 2 years ago

@hsluoyz thanks for the reply. then in this case, what do you suggest we should do in order to release this? not sure if this would count as a 'feat' or 'fix'.

hsluoyz commented 2 years ago

@zillding you can make a new PR to do things like: improve the README.md, add some comments to the code, fix some typos in the English texts, etc. Then use the "fix:" prefix.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: