node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

chore: upgrade sequelize and sequelize-typescript version. #35

Closed stu01509 closed 4 years ago

stu01509 commented 4 years ago

Fix #34

In this PR, I updated the sequelize version to 6.3.5, but sequelize-typescript support sequelize v6 version still in beta.

cc @hsluoyz

hsluoyz commented 4 years ago

Don't use two commits.

hsluoyz commented 4 years ago

@nodece please review.

@stu01509 what I'm worried about is the code quality. Two places need to be improved in such a simple PR.

hsluoyz commented 4 years ago

Plz fix the CI.

nodece commented 4 years ago

@stu01509 What is the reason for closing?

nodece commented 4 years ago

I think it's enough to using sequelize .