search

node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

Fix CI error #56

Closed hsluoyz closed 3 years ago

hsluoyz commented 3 years ago

https://github.com/node-casbin/sequelize-adapter/runs/3091187688?check_suite_focus=true

image

hsluoyz commented 3 years ago

@Zxilly

Zxilly commented 3 years ago

@hsluoyz This issue is caused by an compatible problem between sequelize and sequelize-typescript, this is a known issue at https://github.com/RobinBuschmann/sequelize-typescript/issues/1036 Should we wait for upstream to resolve the bug or downgrade to a lower version?

Zxilly commented 3 years ago

ref to: https://github.com/node-casbin/sequelize-adapter/blob/cf8f725604c198c5abebe228b2f5ad0ae45d4de5/package.json#L44 As for now, yarn will install sequelize 6.6.5 because it is allow by ^6.6.2. But this version is incompatible with sequelize-typescript 2.1.0.

hsluoyz commented 3 years ago

@Zxilly we should downgrade to make sure everything works for each snapshot. Plz make a PR.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: