search

node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

fix: fixing CI error by setting sequelize-typescript to version 2.1.2 #61

Closed samstefan closed 2 years ago

samstefan commented 2 years ago

This pull request fixes https://github.com/node-casbin/sequelize-adapter/issues/60

sequelize-typescript 2.1.3 is not compatible with sequelize 6.10.0 due to this change https://github.com/RobinBuschmann/sequelize-typescript/pull/1202

sequelize-typescript 2.1.3 was being installed in the CI due to the --no-lockfile flag passed to yarn.

casbin-bot commented 2 years ago

@Gabriel-403 @Zxilly @kingiw @nodece please review

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2234879957

Totals Coverage Status
Change from base Build 2234412466: 0.0%
Covered Lines: 100
Relevant Lines: 108
💛 - Coveralls
samstefan commented 2 years ago

@hsluoyz Do you know when this change will be published to NPM?

hsluoyz commented 2 years ago

@samstefan it is supposed to release new version, can you check why it failed?

https://github.com/node-casbin/sequelize-adapter/blob/9c487497e58d680f9f631c6f447c5d45bf43e464/.github/workflows/ci.yml#L43-L65