node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

CI bug: semantic-release failed to release on PR merge #62

Closed hsluoyz closed 2 years ago

hsluoyz commented 2 years ago

See: https://github.com/node-casbin/sequelize-adapter/pull/61#issuecomment-1112174117

casbin-bot commented 2 years ago

@Gabriel-403 @Zxilly @kingiw @nodece

hsluoyz commented 2 years ago

@samstefan

samstefan commented 2 years ago

It would seem that @semantic-release/commit-analyzer doesn't think that changes require a release, I'm not familiar with this tool but I'll try and look into why dependency changes aren't triggering a release.

Logs:

[12:40:58 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[12:40:58 AM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 2 commits complete: no release
[12:40:58 AM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[12:40:58 AM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.
samstefan commented 2 years ago

@hsluoyz Is this because my commit messages didn't follow the semantic-release syntax, I used bug instead of fix?

hsluoyz commented 2 years ago

@samstefan probably, I reverted these two failed commits, please make a new PR.

image

samstefan commented 2 years ago

@hsluoyz https://github.com/node-casbin/sequelize-adapter/pull/63

hsluoyz commented 2 years ago

@samstefan still failed: https://github.com/node-casbin/sequelize-adapter/runs/6220830140?check_suite_focus=true

image

samstefan commented 2 years ago

@hsluoyz I think that was the reverted release and was fixed with https://github.com/node-casbin/sequelize-adapter/pull/63

It looks like the current release is passing and released fine: https://github.com/node-casbin/sequelize-adapter/runs/6228029418?check_suite_focus=true

hsluoyz commented 2 years ago

@samstefan oh, never mind. It's great to see it works! Thx!