feat: Filtered policy support - Githubissues

node-casbin / sequelize-adapter

Sequelize adapter for Casbin

https://github.com/casbin/node-casbin

Apache License 2.0

64 stars 34 forks source link

feat: Filtered policy support #64

Closed rogersgt closed 2 years ago

rogersgt commented 2 years ago

Support for Filtered Policy

Why?

In certain implementations, the casbin rule data store gets quite large for ABAC in an enterprise solution. I would love to be able to use the sequelize adapter with filtered policies in order to load policies by client domains, for example.

What this should do

Added one new method called loadFilteredPolicy according to the casbin adapter documentation
Added a test for loading a filtered policy
Added "es6": true to the .eslintrc to support await Promise.all(). Although I'm happy to revise this to use the syntax of choice.
Moved an await statement in testGetPolicy so that you can actually read the policy in the logs during testing: before:
after:

How to test

yarn test:

Screen Shot 2022-05-25 at 2 19 39 PM

casbin-bot commented 2 years ago

@Gabriel-403 @Zxilly @kingiw @nodece please review

CLAassistant commented 2 years ago

All committers have signed the CLA.

rogersgt commented 2 years ago

@kingiw @nodece or @Gabriel-403 any thoughts about this?

hsluoyz commented 2 years ago

lgtm

hsluoyz commented 2 years ago

@rogersgt can you fix the issue caused by this PR? https://github.com/node-casbin/sequelize-adapter/issues/65

Shivansh-yadav13 commented 2 years ago

could it be because of setiing "es6": true?

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: