search

node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

Fix CI errors #65

Closed hsluoyz closed 2 years ago

hsluoyz commented 2 years ago

https://github.com/node-casbin/sequelize-adapter/runs/8289139592?check_suite_focus=true

Cause by PR: https://github.com/node-casbin/sequelize-adapter/pull/64

image

casbin-bot commented 2 years ago

@nodece @Zxilly @Shivansh-yadav13

hsluoyz commented 2 years ago

@rogersgt

hsluoyz commented 2 years ago

@js-lowes @Shivansh-yadav13 can anyone fix this? It has blocked our releasing process. If no one fixes it, I have to revert the last two PRs.

/cc @nodece

Shivansh-yadav13 commented 2 years ago

@hsluoyz IG you will have to revert #64

js-lowes commented 2 years ago

Will take a look right now. It looks like the tsc command on the prepack is no omitting node_modules files and including them.

js-lowes commented 2 years ago

I think I found the problem. The build/release wasn't using the lockfile, so it probably was install the latest typescript which isn't compatible with the current repo setup instead of using the version locally.

See: https://github.com/node-casbin/sequelize-adapter/pull/68

To reproduce the problem locally run the ci step for release:

yarn install --no-lockfile
yarn run prepack

Then try it with

yarn install --frozen-lockfile
yarn run prepack

@hsluoyz Please validate the fix and merge https://github.com/node-casbin/sequelize-adapter/pull/68