search

node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

feat: Optionally set the schema for table creation #66

Closed js-lowes closed 2 years ago

js-lowes commented 2 years ago

Support to optionally set the schema for table

Why?

Some RDBMS support the idea of schema being a separated namespace under a database, e.g. Postgres.

What was changed?

  1. Propagate the schema option to the table creation exactly how tableName was propagated.
  2. Updated README to include instructions on how to test locally
casbin-bot commented 2 years ago

@nodece @Zxilly @Shivansh-yadav13 please review

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

hsluoyz commented 2 years ago

@nodece @Zxilly @Shivansh-yadav13 please review

js-lowes commented 2 years ago

@hsluoyz had a lint error, I fixed it

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 3083837725

Totals Coverage Status
Change from base Build 3030254759: 0.09%
Covered Lines: 113
Relevant Lines: 122
💛 - Coveralls
Zxilly commented 2 years ago

lgtm, but please follow semantic commit rules.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: