search

node-casbin / sequelize-adapter

Sequelize adapter for Casbin
https://github.com/casbin/node-casbin
Apache License 2.0
64 stars 34 forks source link

feat: Optionally skip create table with argument to newAdapter #71

Closed rogersgt closed 1 year ago

rogersgt commented 1 year ago

Fix: https://github.com/casbin/node-casbin/issues/418

See my question int he issues section of the node-casbin repo: https://github.com/casbin/node-casbin/issues/418. If there is already a way to do this, or a better pattern, I'm all for it. But I really think this is needed for many enterprise implementations.

casbin-bot commented 1 year ago

@nodece @Zxilly @Shivansh-yadav13 please review

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4056270362

Totals Coverage Status
Change from base Build 3105386997: -0.05%
Covered Lines: 116
Relevant Lines: 125
💛 - Coveralls
hsluoyz commented 1 year ago

@rogersgt

hsluoyz commented 1 year ago

@rogersgt hi, can you fix the issues according to the review?

hsluoyz commented 1 year ago

Replaced by: https://github.com/node-casbin/sequelize-adapter/pull/73

rogersgt commented 1 year ago

Sorry for the delay here. Thanks for making the change @terry-xuan-gao!