search

node-ci / nci-classic-ui

First ui for nci
Other
2 stars 6 forks source link

proper scm icons #3

Closed fleg closed 8 years ago

fleg commented 8 years ago

git: screenshot from 2016-03-17 23_10_52

hg: screenshot from 2016-03-17 23_11_58

okv commented 8 years ago

:+1:

okv commented 8 years ago

I found that scmicons font have wrong paddings because of that icon not vertically aligned. Is it possible to fix? On your screenshots you can compare vertical alignment with icon near "Build history" (which is correct).

fleg commented 8 years ago

Is it possible to fix?

I investigate that

artzhookov commented 8 years ago

It's not a good idea to use "vertical-align: middle" because you may need another vertical align. Fontawesome does not specify it and I think you should use similar styles here. This problem should be fixed by rebuilding font files with additional vertical spaces inside of font.

fleg commented 8 years ago

In scmicons@1.3.0 vertical-align removed