search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 95 forks source link

devices configuration removed from file and into library #12

Closed ghost closed 8 years ago

ghost commented 8 years ago

the use of devices.js makes it very difficult to change the devices being controlled without changing the code for node-dmx itself. I have made a small change and now the devices' are declared with the loading of the library.

wiedi commented 8 years ago

Thanks!

I've accepted this in 31c6fd12907062ce392c7ca3f5b688e338f5f719 - but still keep the current devices library around as a starting point. I've also made a follow-up commit cd48f76ef3404dfbe5354865f09c568f0760cb9d that makes passing "devices" optional and allows for future extension without breaking any users. This also fixes the webinterface.