search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 95 forks source link

Add BeagleBone-DMX driver #19

Closed xuio closed 7 years ago

xuio commented 7 years ago

I added compatibility with https://github.com/boxysean/beaglebone-DMX (Beaglebone-PRU-DMX driver). It works well, tested on my BeagleBone Black

wiedi commented 7 years ago

Also, to quote the protocol description: A single space is expected between the values, and there should be no space after the last value.

Currently there will be a space in the end, wouldn't it be better to conform to this?

xuio commented 7 years ago

Thanks for noticing. You're totally right, I just pushed a fix.

Should I also remove the let and const variable prefixes for backwards compatibility? iirc they can be used in strict mode with older node versions.

wiedi commented 7 years ago

I think those are fine, at least with 0.12