Update codebase to recover compatibility

node-dmx / dmx

DMX controller library for node.js

MIT License

297 stars 95 forks source link

Update codebase to recover compatibility #33

Closed Fensterbank closed 6 years ago

Fensterbank commented 6 years ago

This pull request merges relevant commits from another fork to the main repository. Source code is updated to ES2015+ and the packages are updated to the latest major version to recover compatibility with Node 7+.

Merging this pull request fixes #25 and makes #31 and #32 obsolete.

Fensterbank commented 6 years ago

missed a few things.

Fensterbank commented 6 years ago

now all things are done and the PR is ready to merge. @wiedi would you please check this and the other pull requests?

wiedi commented 6 years ago

Hi, thanks for picking this up and apologies for the delay!

There's a lot going on in this PR.

devices.js looks fine
if we'd decide to ship an example dmx-web.json maybe better to rename the existing one?
package.json - should not change the url, why is color-convert a dev-dependency?
pliabAnim.js - what does "pliab" stand for? Maybe this deserves a note/example in the readme?

Fensterbank commented 6 years ago

Oh, yes. You're right. It seems with the commits of thomfort we have a few more weird things we don't want or need. I did not notice this. I think I will recreate my branch by concentrating on package upgrades and ignoring the other commits from thomfort. Stay tuned...

Fensterbank commented 6 years ago

Obsolete