search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 95 forks source link

Add a new device to support RGB on Ultra Pro devices #48

Closed spearway closed 6 years ago

spearway commented 6 years ago

I need this new device to enable the management of the 24ch Ultra Pro as 6 RGBW channels

Fensterbank commented 6 years ago

Hello @spearway and thank you for your pull request. I just force pushed an update to your branch, so that the original format (tab size 4, not spaces) is preserved. Otherwise we would mess up the diff a bit. If you work on your branch, please make a git pull first.

Can you please explain, what you tried to achieve with channelgoups. Not only is this misspelled, such a property is not used anywhere in code.

Fensterbank commented 6 years ago

@spearway Thanks for fixing the spelling mistake. But my question still stands? What is the purpose of this property?

channelgroups is not used anywhere in the code base, so I don't see the reason to add it. Or did I miss something here?

bluemaex commented 6 years ago

@Fensterbank I think I know for what that property is :)

I just saw that @spearway also did a Pull Request to the Homebridge-DMXUniverse Plugin (https://github.com/bluemaex/homebridge-dmxuniverse/pull/4) to control those Lights via HomeKit - That is where this property is used. (Sorry, I did not find time to review it yet, but I will try to do it this this week.)

spearway commented 6 years ago

Sorry yes I needed that for creating the right accessories in home bridge. I got it working very nicely in home kit.

Fensterbank commented 6 years ago

Thanks for clarification. Looks fine so far. Merged! 🍪