search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 95 forks source link

Make it possible to define devices in the config file #50

Closed spearway closed 5 years ago

spearway commented 6 years ago

https://github.com/wiedi/node-dmx/blob/4cbfb8cc1d596b1b257e65f6109d7fe0f28e6225/dmx-web.js#L25-L27

I think there is a mistake this should be: var dmx = new DMX(config)

as DMX is defined as: function DMX(options) {}

This would enable having a device section in the config file to override the build in devices.

spearway commented 6 years ago

https://github.com/wiedi/node-dmx/pull/64

spearway commented 5 years ago

this is merged closing