search

node-dmx / dmx

DMX controller library for node.js
MIT License
297 stars 95 forks source link

Add Color Picker #55

Closed pboyd04 closed 6 years ago

pboyd04 commented 6 years ago

Add a color picker for any devices that have RGB channels (right now they have to be named "red", "green", and "blue") so the stairville-led-par-56, lixda-par12-led, eurolite-led-tha-120PC, briteq-bt-theatre-60FC, and (if #51 is accepted) those two devices will work. Others won't right now.

bluemaex commented 6 years ago

Uh that is an interesting UX in macOS - today I learned about input type = 'color' :)

Not the nicest UI imho, but it fits in perfectly to the current state of the rest 😆 - perfect for the first iteration thanks 👍

pboyd04 commented 6 years ago

Can't really control the UI that various OSes/browsers put on it. The phone one in particular is really bizarre. But it does open the door for a nicer UI addition later.

Fensterbank commented 6 years ago

Yeah <input type="color"> looks different in every browser or OS and is often unsupported, but since the UI is not great anyway, it is good enough to make it like this. 😉

But it does open the door for a nicer UI addition later.

There are people and projects working on a React client, which only uses node-dmx as the backend API. node-dmx is a great library with a very functional oldschool UI. I wouldn't stop anyone, but I don't see the benefit in improving that UI, it's better to build new clients with modern web development techniques.