search

node-escpos / driver

🖨️ ESC/POS Printer driver for Node.js.
Other
287 stars 27 forks source link

feat: top and bottom logo functions #55

Closed dschweinbenz closed 1 year ago

dschweinbenz commented 1 year ago

Added functions to set the top or bottom logo from the NV memory using keycodes

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 7d6c5973c27b5fbd19917a5e0dfeab2f0a5217d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @node-escpos/core | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dohooo commented 1 year ago

Cool! Thanks for your contribution! Could you add some tests for the code?

dschweinbenz commented 1 year ago

Cool! Thanks for your contribution! Could you add some tests for the code?

Not sure as the most logic is done inside the printer? I could test if the buffer contains the correct hex sequence or if the parameter checks are thrown?