node-escpos / driver

🖨️ ESC/POS Printer driver for Node.js.
Other
309 stars 30 forks source link

feat!: Made list() a static function #58

Closed dschweinbenz closed 1 year ago

dschweinbenz commented 1 year ago

BREAKING CHANGE: list() is now static and not callable from the serial object

It doesn't really make sense to call the list() function if one have already initialized an object with a serial path. The list() function lists possible serial paths and devices. Therefore its use is in my eyes normally before initializing an object with a known path. Also the list() is independend from on the object.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 5c6f40510582ceeef6657766588e9f2f4e3dc161

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------- | ----- | | @node-escpos/serialport-adapter | Major |

Not sure what this means? Click here to learn what changesets are.

[Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/dschweinbenz/node-escpos/new/feature/serial-list?filename=.changeset/shaggy-gifts-battle.md&value=---%0A%22%40node-escpos%2Fserialport-adapter%22%3A%20patch%0A---%0A%0Afeat!%3A%20Made%20list()%20a%20static%20function%0A)

dohooo commented 1 year ago

thx.