Open Xelio opened 5 months ago
Latest commit: 98606bdeaa82362edf239c99db746e934df2af63
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
[Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/Xelio/node-escpos-driver/new/fix-network-adapter?filename=.changeset/fast-countries-tickle.md&value=---%0A%22%40node-escpos%2Fcore%22%3A%20patch%0A%22%40node-escpos%2Fnetwork-adapter%22%3A%20patch%0A---%0A%0AFix%20issues%20in%20network%20adapter%20and%20core%20getStatus()%2C%20getStatuses()%0A)
Hi @dohooo, This PR is mainly for network printer. I only has network printer, so can't test it on USB/Serial/BT printer. Would you help to test on USB/Serial/BT printer, and see if there is any problem?
⚠️ No Changeset found
Latest commit: 4a2bdbc
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/Xelio/node-escpos-driver/new/fix-network-adapter?filename=.changeset/brave-dingos-kneel.md&value=---%0A%22%40node-escpos%2Fcore%22%3A%20patch%0A%22%40node-escpos%2Fnetwork-adapter%22%3A%20patch%0A---%0A%0AFix%20issues%20in%20network%20adapter%20and%20core%20getStatus()%2C%20getStatuses()%0A)
@Xelio Thanks for your effort, awesome work! But before I merge it, could you add a changeset for these changes? BTW, Can you add unit test for this PR.
Looking forward to this release! Will probably fix many of the issues I am having, as I use Network printer for my main use-case. No rush, but add a changeset and unit test please?
Hoping to see this merged soon!
Hi @dohooo , Tests and changeset added, please take a look, thanks!