node-facebook / facebook-node-sdk

Modeled from the (Facebook Javascript SDK), now with the facebook-node-sdk you can now easily write the same code and share between your server (nodejs) and the client (Facebook Javascript SDK).
Other
529 stars 114 forks source link

Remove FB.napi #153

Open dantman opened 6 years ago

dantman commented 6 years ago

For some time this library has supported an alternative FB.napi which uses a Node style callback instead of the one Facebook uses.

I generally do not know if anyone actually benefits from this anymore:

However this is a big breaking change that will force people to refactor their code if it turns out there is a segment of users that still uses the node style callbacks.

Thus my current plan is to release 3.0.0 with modification to napi that emits a warning when used saying that we plan to remove this api and pointing to this bug report if people want it.

If I do not get a significant number of people commenting in favour of keeping napi in this bug, I will remove napi in 4.0.0.