search

node-ffi / node-ffi

Node.js Foreign Function Interface
MIT License
4.25k stars 414 forks source link

warning 'v8::Object::ForceSet': was declared deprecated #376

Open fredericrous opened 7 years ago

fredericrous commented 7 years ago

got this node-gyp warning on windows10 with nodejs 7.7.4

> ffi@2.2.0 install C:\lupin8\node_modules\ffi
> node-gyp rebuild

C:\lupin8\node_modules\ffi>if not defined npm_config_node_gyp (node "C:\nvm\v7.7.4\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  Building assembly file ..\..\..\deps\libffi\src\x86\win64.asm
   Assembling: ..\..\..\deps\libffi\src\x86\win64.asm
  prep_cif.c
  types.c
  raw_api.c
  java_raw_api.c
  closures.c
  ffi.c
  win_delay_load_hook.cc
  ffi.vcxproj -> C:\lupin8\node_modules\ffi\build\Release\\libffi.lib
  ffi.cc
  callback_info.cc
  threaded_callback_invokation.cc
  win32-dlfcn.cc
  win_delay_load_hook.cc
..\src\ffi.cc(111): warning C4996: 'v8::Object::ForceSet': was declared deprecated [C:\lupin8\node_m
odules\ffi\build\ffi_bindings.vcxproj]
  c:\.node-gyp\7.7.4\include\node\v8.h(2957): note: see declaration of 'v8::Object::ForceSet'
..\src\ffi.cc(114): warning C4996: 'v8::Object::ForceSet': was declared deprecated [C:\lupin8\node_m
odules\ffi\build\ffi_bindings.vcxproj]
jsshizhan commented 7 years ago

i have the issue too

mempf commented 7 years ago

Same with node 8.2.1. Should we expect this to break node-ffi sometime soon in a new Node/V8 release without a patch?

springmeyer commented 6 years ago

See https://github.com/nodejs/nan/issues/504