search

node-formidable / formidable

The most used, flexible, fast and streaming parser for multipart form data. Supports uploading to serverless environments, AWS S3, Azure, GCP or the filesystem. Used in production.
MIT License
7.01k stars 680 forks source link

Formidable.js refers to errors.pluginFailed but FormidableError.js does not export it #793

Closed gcatto closed 2 years ago

gcatto commented 2 years ago

I am using formidable@3.1.3 and for complicated reasons, I am bundling my web server using webpack. When doing so, it complained that Formidable.js refers to errors.pluginFailed but that FormidableError.js does not export it.

See https://github.com/node-formidable/formidable/blob/master/src/Formidable.js#L409 and https://github.com/node-formidable/formidable/blob/master/src/FormidableError.js#L25

Should it be missingPlugin instead? Or something else?

GrosSacASac commented 2 years ago

Something is missing

GrosSacASac commented 2 years ago

can you try again with the fix-missing-pluginFailed branch ?

gcatto commented 2 years ago

@GrosSacASac yeah, that branch does the trick for me. Thanks for the prompt work!

GrosSacASac commented 2 years ago

published 3.1.4

GrosSacASac commented 2 years ago

please help review https://github.com/node-formidable/formidable/pull/791