node-formidable / formidable

The most used, flexible, fast and streaming parser for multipart form data. Supports uploading to serverless environments, AWS S3, Azure, GCP or the filesystem. Used in production.
MIT License
7.04k stars 682 forks source link

npm module formidable@2.0.1 marked as latest #865

Closed leonidio-com closed 2 years ago

leonidio-com commented 2 years ago

Support plan

Context

What are you trying to achieve or the steps to reproduce?

Our security scans find a vulnerability in formidable@2.0.1 (CVE-2022-29622).

const some = 'properly formatted code example';

What was the result you got?

formidable@2.0.1 is pulled in by superagent@7.1.6 in our product. Even though superagent@7.1.6 is very new it still pulls formidable@2.0.1 Looking at that page here: https://www.npmjs.com/package/formidable we can see that formidable@2.0.1 marked as latest - this might explain why superagent@7.1.6 pulls formidable@2.0.1 instead of formidable@3.2.4

What result did you expect?

We expect all the products to pull the latest and greatest formidable with all the CVE's fixed.

tunnckoCore commented 2 years ago

yes. that's how it works.

It's not marked as latest for a reason.

check #856, #862, and superagent's one https://github.com/visionmedia/superagent/issues/1725#issuecomment-1150285639 and https://github.com/visionmedia/superagent/pull/1724.

The vulnerability is not as severe as everyone is making it out to be.

They are not that effected.