node-formidable / formidable

The most used, flexible, fast and streaming parser for multipart form data. Supports uploading to serverless environments, AWS S3, Azure, GCP or the filesystem. Used in production.
MIT License
7k stars 680 forks source link

Refactor: Consider removing usage of setTimeout #894

Open GrosSacASac opened 1 year ago

GrosSacASac commented 1 year ago

What problem are you trying to solve?

https://github.com/node-formidable/formidable/pull/798/commits/a11190f7e4e40de8f799cece87e56a59dc63164f

Maybe do not use setTimeout

Do you have a new or modified API suggestion to solve the problem?

Use on('close' callback.

Other

Not sure, this is race condition specific, so traditional unit tests don't work